Upgraded semantic conventions to 1.18.0 #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded semantic conventions to 1.18.0
lalitb
approved these changes
Feb 9, 2023
ThomsonTan
reviewed
Feb 9, 2023
| @@ -30,6 +35,12 @@ git fetch origin "$SPEC_VERSION" | |||
| git reset --hard FETCH_HEAD | |||
| cd ${SCRIPT_DIR} | |||
|
|
|||
| # echo "Help ..." | |||
There was a problem hiding this comment.
Is this some temporary code?
There was a problem hiding this comment.
This is for maintainers, to get the command line help of the tool itself, if needed.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
=======================================
Coverage 87.12% 87.12%
=======================================
Files 165 165
Lines 4596 4596
=======================================
Hits 4004 4004
Misses 592 592
|
esigo
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1973
Changes
Upgraded semantic conventions to 1.18.0
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes