Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate CPack for binary package #1835

Closed
wants to merge 3 commits into from
Closed

Integrate CPack for binary package #1835

wants to merge 3 commits into from

Conversation

flier
Copy link
Contributor

@flier flier commented Dec 2, 2022

Fixes #1834

Changes

Please provide a brief description of the changes here.

  • Integrate CPack in the CMake build system
  • Generate binary package with make package or ninja package

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@flier flier requested a review from a team December 2, 2022 05:52
@codecov
Copy link

codecov bot commented Dec 2, 2022 •
edited
Loading

Codecov Report

Merging #1835 (9e9ea42) into main (d74e02f) will increase coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
+ Coverage   85.71%   85.79%   +0.08%     
==========================================
  Files         171      171              
  Lines        5240     5240              
==========================================
+ Hits         4491     4495       +4     
+ Misses        749      745       -4
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.41% <0.00%> (+0.79%) ⬆️
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

@lalitb
Copy link
Member

lalitb commented Dec 2, 2022 •
edited
Loading

@flier - Would it be fine if we track the fix through #1662. Plan to include CPack conditionally, and also provide scripts for deb and rpm. I can push it for next release as there are multiple asks for packaging.

owent
owent approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flier
Copy link
Contributor Author

flier commented Dec 2, 2022

@owent

@lalitb lalitb added the pr:do-not-merge This PR is not ready to be merged. label Dec 3, 2022
esigo
esigo requested changes Dec 4, 2022
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked per #1835 (comment)

@esigo esigo added the area:build OpenTelemetry build label Dec 4, 2022
@lalitb
Copy link
Member

lalitb commented Dec 12, 2022

closing this for #1662

@lalitb lalitb closed this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo requested changes

@owent owent owent approved these changes

Assignees
No one assigned
Labels
area:build OpenTelemetry build pr:do-not-merge This PR is not ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate CPack for binary package
4 participants
@flier @lalitb @owent @esigo