Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics SDK] Change Prometheus CMake target name #1765

Merged
merged 3 commits into from
Nov 12, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 11, 2022

Fixes #1764

Changed the target name to opentelemetry_exporter_prometheus .

$ ls /usr/local/lib/libopentelemetry_* -ltr
-rw-r--r-- 1 root root  5884858 Oct 28 08:10 /usr/local/lib/libopentelemetry_proto.a
-rw-r--r-- 1 root root   874006 Oct 28 16:19 /usr/local/lib/libopentelemetry_otlp_recordable.a
-rw-r--r-- 1 root root     3300 Nov 10 16:11 /usr/local/lib/libopentelemetry_version.a
-rw-r--r-- 1 root root   144904 Nov 10 16:11 /usr/local/lib/libopentelemetry_common.a
-rw-r--r-- 1 root root  2794826 Nov 10 16:11 /usr/local/lib/libopentelemetry_resources.a
-rw-r--r-- 1 root root  1910868 Nov 10 16:11 /usr/local/lib/libopentelemetry_http_client_curl.a
-rw-r--r-- 1 root root  5777388 Nov 10 16:11 /usr/local/lib/libopentelemetry_trace.a
-rw-r--r-- 1 root root 19873766 Nov 10 16:11 /usr/local/lib/libopentelemetry_metrics.a
-rw-r--r-- 1 root root  1559820 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_ostream_metrics.a
-rw-r--r-- 1 root root  2175672 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_prometheus.a
-rw-r--r-- 1 root root  2887576 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_ostream_span.a
-rw-r--r-- 1 root root  2444300 Nov 10 16:13 /usr/local/lib/libopentelemetry_exporter_in_memory.a
-rw-r--r-- 1 root root   411284 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_client.a
-rw-r--r-- 1 root root     2518 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_log.a
-rw-r--r-- 1 root root  1780364 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http_client.a
-rw-r--r-- 1 root root   941658 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http_metric.a
-rw-r--r-- 1 root root  1017242 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_http.a
-rw-r--r-- 1 root root  1021982 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc_metrics.a
-rw-r--r-- 1 root root  1093522 Nov 10 16:24 /usr/local/lib/libopentelemetry_exporter_otlp_grpc.a
-rw-r--r-- 1 root root  4246512 Nov 10 16:29 /usr/local/lib/libopentelemetry_exporter_zipkin_trace.a

@lalitb lalitb requested a review from a team November 11, 2022 00:27
@lalitb lalitb changed the title change prometheus cmake target name [Metrics SDK] Change Prometheus CMake target name Nov 11, 2022
exporters/prometheus/CMakeLists.txt Outdated Show resolved Hide resolved
exporters/prometheus/CMakeLists.txt Outdated Show resolved Hide resolved
exporters/prometheus/CMakeLists.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1765 (31cd053) into main (b157216) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1765   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files         171      171           
  Lines        5212     5212           
=======================================
  Hits         4471     4471           
  Misses        741      741           

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with format fix

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix :)

@esigo esigo enabled auto-merge (squash) November 12, 2022 19:40
@esigo
Copy link
Member

esigo commented Nov 12, 2022

I think we need to clean cache:

FATAL: corrupt installation: file '/Users/runner/.cache/bazel/install/055c20a5e[6](https://github.com/open-telemetry/opentelemetry-cpp/actions/runs/3441965197/jobs/5762053586#step:4:7)23d48b44a7c0f17b28c93a/A-server.jar' is missing or modified.  Please remove '/Users/runner/.cache/bazel/install/055c20a5e623d48b44a7c0f17b28c93a' and try again.
Error: Process completed with exit code 36.

can be done as explained here

@esigo esigo merged commit 389b84f into open-telemetry:main Nov 12, 2022
@lalitb
Copy link
Member Author

lalitb commented Nov 13, 2022

I think we need to clean cache:

FATAL: corrupt installation: file '/Users/runner/.cache/bazel/install/055c20a5e[6](https://github.com/open-telemetry/opentelemetry-cpp/actions/runs/3441965197/jobs/5762053586#step:4:7)23d48b44a7c0f17b28c93a/A-server.jar' is missing or modified.  Please remove '/Users/runner/.cache/bazel/install/055c20a5e623d48b44a7c0f17b28c93a' and try again.
Error: Process completed with exit code 36.

can be done as explained here

Thanks @esigo .

yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics SDK] Inconsistent CMake target name for Prometheus exporter
4 participants