Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade opentelemetry-proto to v0.19.0 #1579

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Aug 22, 2022

Fixes # N/A

Changes

Upgrade otlp-proto

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team August 22, 2022 22:06
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1579 (36cc18b) into main (ef4136e) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
+ Coverage   85.00%   85.02%   +0.03%     
==========================================
  Files         156      156              
  Lines        4977     4977              
==========================================
+ Hits         4230     4231       +1     
+ Misses        747      746       -1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 91.41% <0.00%> (+0.79%) ⬆️

@ThomsonTan
Copy link
Contributor

Is there any breaking change for the upgrade?

@lalitb
Copy link
Member Author

lalitb commented Aug 22, 2022

Is there any breaking change for the upgrade?

No breaking change. This version removes instrumentationlibrary, and adds support for partial success for otlp response.

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb merged commit 39d6a22 into open-telemetry:main Aug 23, 2022
@lalitb lalitb deleted the otlp-proto-0.19.0 branch August 23, 2022 01:51
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
* changes

* add changelog

* update third_party_release
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
* changes

* add changelog

* update third_party_release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants