[NFC] Improve scope/instrument names in metrics ostream exporter #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were overloading the `name` key in the metrics ostream exporter. This patch qualifies the `name` key with the appropriate prefix based on the structures they represent.
bsarden
commented
Aug 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #1544 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 156 156
Lines 4908 4908
=======================================
Hits 4119 4119
Misses 789 789
|
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were overloading the
namekey in the metrics ostreamexporter. This patch qualifies the
namekey with the appropriate prefixbased on the structures they represent.