upgrade opentelemetry-proto from v0.11.0 to v0.15.0 #1290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 213 213
Lines 7532 7532
=======================================
Hits 6944 6944
Misses 588 588 |
ThomsonTan
reviewed
Mar 26, 2022
| @@ -5,6 +5,6 @@ benchmark=v1.5.3 | |||
| googletest=release-1.8.0-2523-ga6dfd3ac | |||
| ms-gsl=v1.0.0-393-g6f45293 | |||
| nlohmann-json=v3.9.1 | |||
| opentelemetry-proto=v0.11.0 | |||
| opentelemetry-proto=v0.11.0-16-g3c2915c | |||
There was a problem hiding this comment.
Should here be 0.15.0 as well?
There was a problem hiding this comment.
It's strange this is what git submodule returns.
There were some breaking changes, I need to fix them for the upgrade.
There was a problem hiding this comment.
There were some breaking changes, I need to fix them for the upgrade.
Is it related to proto file changes for logs sdk?
There was a problem hiding this comment.
yes, it should be related to log.
|
closing as it is blocked by #1291. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade opentelemetry-proto to the latest release
Changes
upgrade opentelemetry-proto to v0.15.0
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes