-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade opentelemetry-proto from v0.11.0 to v0.15.0 #1290
upgrade opentelemetry-proto from v0.11.0 to v0.15.0 #1290
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 213 213
Lines 7532 7532
=======================================
Hits 6944 6944
Misses 588 588 |
@@ -5,6 +5,6 @@ benchmark=v1.5.3 | |||
googletest=release-1.8.0-2523-ga6dfd3ac | |||
ms-gsl=v1.0.0-393-g6f45293 | |||
nlohmann-json=v3.9.1 | |||
opentelemetry-proto=v0.11.0 | |||
opentelemetry-proto=v0.11.0-16-g3c2915c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should here be 0.15.0 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange this is what git submodule
returns.
There were some breaking changes, I need to fix them for the upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some breaking changes, I need to fix them for the upgrade.
Is it related to proto file changes for logs sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it should be related to log.
closing as it is blocked by #1291. |
upgrade opentelemetry-proto to the latest release
Changes
upgrade opentelemetry-proto to v0.15.0
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes