Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meter and MeterProvider in the SDK #1078

Merged
merged 15 commits into from
Nov 30, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 20, 2021

Add

  • Meter and MeterProvider in the SDK,
  • placeholder for MeterExporter, MeterReader and View class.
  • Internally used MeterContext class.

@lalitb lalitb requested a review from a team November 20, 2021 00:30
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #1078 (f6df863) into main (6b9ed3d) will decrease coverage by 1.02%.
The diff coverage is 51.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1078      +/-   ##
==========================================
- Coverage   94.41%   93.39%   -1.01%     
==========================================
  Files         158      165       +7     
  Lines        6077     6229     +152     
==========================================
+ Hits         5737     5817      +80     
- Misses        340      412      +72     
Impacted Files Coverage Δ
api/include/opentelemetry/metrics/meter.h 100.00% <ø> (ø)
...lude/opentelemetry/sdk/common/global_log_handler.h 80.00% <ø> (+8.00%) ⬆️
sdk/src/metrics/meter.cc 14.29% <14.29%> (ø)
sdk/src/metrics/meter_context.cc 40.00% <40.00%> (ø)
sdk/src/metrics/meter_provider.cc 78.13% <78.13%> (ø)
sdk/test/metrics/meter_provider_sdk_test.cc 80.00% <80.00%> (ø)
...nclude/opentelemetry/sdk/metrics/metric_exporter.h 100.00% <100.00%> (ø)
.../include/opentelemetry/sdk/metrics/metric_reader.h 100.00% <100.00%> (ø)
sdk/include/opentelemetry/sdk/metrics/view.h 100.00% <100.00%> (ø)

@lalitb lalitb changed the title [WIP] Add Meter and MeterProvider in the SDK Add Meter and MeterProvider in the SDK Nov 22, 2021
@lalitb lalitb merged commit b1b1f64 into open-telemetry:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants