Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlp_grpc_exporter export after shutdown should fail #1050

Merged

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 2, 2021

according to the exporter specifications, export after shutdown should fail

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team November 2, 2021 21:15
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1050 (3166535) into main (52f6198) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   94.85%   94.83%   -0.01%     
==========================================
  Files         151      151              
  Lines        5971     5971              
==========================================
- Hits         5663     5662       -1     
- Misses        308      309       +1     
Impacted Files Coverage Δ
...include/opentelemetry/sdk/common/circular_buffer.h 97.92% <0.00%> (-2.08%) ⬇️

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@ThomsonTan ThomsonTan merged commit 8e8c50a into open-telemetry:main Nov 3, 2021
@esigo esigo deleted the otl_grpc_exporter-export-after-shutdown branch November 4, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants