Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics API] Add support for histogram advice API #2132

Open
lalitb opened this issue May 5, 2023 · 7 comments
Open

[Metrics API] Add support for histogram advice API #2132

lalitb opened this issue May 5, 2023 · 7 comments
Labels
breaking change API or ABI breaking change do-not-stale

Comments

@lalitb
Copy link
Member

lalitb commented May 5, 2023

Experimental histogram advice API to enable instrumentation library suggest histogram buckets - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-advice

@marcalff
Copy link
Member

Adding the breaking change label: this will require a new or changed API, hence changing the API ABI for metrics.

@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Aug 19, 2023
@lalitb lalitb added do-not-stale and removed Stale labels Aug 19, 2023
@marcalff marcalff removed this from the Metrics post GA release - 2 milestone Jan 29, 2024
@dufferzafar
Copy link

Is the Advice / Hints API still experimental? open-telemetry/opentelemetry-specification#2229

The go client already has support for it now: open-telemetry/opentelemetry-go#4605

@Falmarri
Copy link

Falmarri commented Apr 3, 2024

The java client as well. Not really sure how to use histograms at all without that

@lalitb
Copy link
Member Author

lalitb commented Apr 3, 2024

@Falmarri - The histogram buckets can be still configured using View API. Or let us know if you are looking for specific configuration from advisory API.

@Falmarri
Copy link

Falmarri commented Apr 3, 2024

@lalitb Did I miss docs on this? Is there an example? This is using the sdk classes, right?

@lalitb
Copy link
Member Author

lalitb commented Apr 3, 2024

Yes, there are unit-tests for custom buckets -

TEST(Histogram, DoubleCustomBuckets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change API or ABI breaking change do-not-stale
Projects
None yet
Development

No branches or pull requests

4 participants