Skip to content

Commit

Permalink
[CI] Upgrade to abseil 20240116.1 (CMake only) (#2599)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcalff committed Mar 28, 2024
1 parent 3adcc79 commit fabd8cc
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 5 deletions.
10 changes: 8 additions & 2 deletions api/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,14 @@ if(WITH_ABSEIL)
target_link_libraries(
opentelemetry_api INTERFACE absl::bad_variant_access absl::any absl::base
absl::bits absl::city)
list(APPEND TARGET_DEPS "absl_bad_variant_access" "absl_any absl_base"
"absl_bits" "absl_city")
list(
APPEND
TARGET_DEPS
"absl_bad_variant_access"
"absl_any"
"absl_base"
"absl_bits"
"absl_city")
endif()

if(WITH_STL STREQUAL "OFF")
Expand Down
7 changes: 7 additions & 0 deletions bazel/repository.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ def opentelemetry_cpp_deps():

# Load abseil dependency(optional)
maybe(
#
# Important note:
#
# The bazel build still uses abseil-cpp-20220623.1 here.
#
# Upgrading to abseil-cpp-20240116.1 breaks the OTLP build, reason unknown.
#
http_archive,
name = "com_google_absl",
sha256 = "91ac87d30cc6d79f9ab974c51874a704de9c2647c40f6932597329a282217ba8",
Expand Down
2 changes: 1 addition & 1 deletion ci/do_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ elif [[ "$1" == "code.coverage" ]]; then
exit 0
elif [[ "$1" == "third_party.tags" ]]; then
echo "gRPC=v1.49.2" > third_party_release
echo "abseil=20220623.1" >> third_party_release
echo "abseil=20240116.1" >> third_party_release
git submodule foreach --quiet 'echo "$name=$(git describe --tags HEAD)"' | sed 's:.*/::' >> third_party_release
exit 0
fi
Expand Down
2 changes: 1 addition & 1 deletion ci/install_abseil.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

set -ex
export DEBIAN_FRONTEND=noninteractive
[ -z "${ABSEIL_CPP_VERSION}" ] && export ABSEIL_CPP_VERSION="20220623.1"
[ -z "${ABSEIL_CPP_VERSION}" ] && export ABSEIL_CPP_VERSION="20240116.1"

BUILD_DIR=/tmp/
INSTALL_DIR=/usr/local/
Expand Down
2 changes: 1 addition & 1 deletion third_party_release
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#

gRPC=v1.49.2
abseil=20220623.1
abseil=20240116.1
benchmark=v1.8.3
googletest=1.14.0
ms-gsl=v3.1.0-67-g6f45293
Expand Down

0 comments on commit fabd8cc

Please sign in to comment.