PR comments

open-telemetry · Mar 25, 2020 · 8925bea · 8925bea
1 parent 9a9e331
commit 8925bea
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/sdk/include/opentelemetry/sdk/trace/processor.h b/sdk/include/opentelemetry/sdk/trace/processor.h
@@ -35,6 +35,10 @@ class SpanProcessor
       std::chrono::microseconds timeout = std::chrono::microseconds(0)) noexcept = 0;
 
   // Shut down the processor and do any cleanup required.
+  //
+  // Ended spans are exported before shutdown. After the call to Shutdown,
+  // subsequent calls to OnStart, OnEnd, ForceFlush or Shutdown will return
+  // immediately without doing anything.
   virtual void Shutdown() noexcept = 0;
 };
 }  // namespace trace

diff --git a/sdk/src/trace/recordable.h → ...lude/opentelemetry/sdk/trace/recordable.h b/sdk/src/trace/recordable.h → ...lude/opentelemetry/sdk/trace/recordable.h
diff --git a/sdk/include/opentelemetry/sdk/trace/span_data.h b/sdk/include/opentelemetry/sdk/trace/span_data.h
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <chrono>
 #include "opentelemetry/core/timestamp.h"
 #include "opentelemetry/nostd/string_view.h"
 #include "opentelemetry/sdk/trace/recordable.h"
@@ -36,8 +37,8 @@ class SpanData final : public Recordable
   // The start time of this span.
   opentelemetry::core::SystemTimestamp GetStartTime() const noexcept = 0;
 
-  // The end time of this span.
-  opentelemetry::core::SystemTimestamp GetEndTime() const noexcept = 0;
+  // The duration of this span.
+  std::chrono::nanoseconds GetDuration() const noexcept = 0;
 };
 }  // namespace trace
 }  // namespace sdk

diff --git a/sdk/src/trace/recorder.h b/sdk/src/trace/recorder.h
@@ -1,9 +1,9 @@
 #pragma once
 
+#include "opentelemetry/sdk/trace/recordable.h"
 #include "opentelemetry/trace/span_id.h"
 #include "opentelemetry/trace/trace_id.h"
 #include "opentelemetry/version.h"
-#include "src/trace/recordable.h"
 
 OPENTELEMETRY_BEGIN_NAMESPACE
 namespace sdk