use _mm_pause instead of __builtin_ia_32_pause when __INTEL_COMPILER …

…defined (#1885)
open-telemetry · Dec 22, 2022 · 8866c10 · 8866c10 · github-actions · Dec 22, 2022
1 parent 9dd19a2
commit 8866c10
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/api/include/opentelemetry/common/spin_lock_mutex.h b/api/include/opentelemetry/common/spin_lock_mutex.h
@@ -18,6 +18,8 @@
 #elif defined(__i386__) || defined(__x86_64__)
 #  if defined(__clang__)
 #    include <emmintrin.h>
+#  elif defined(__INTEL_COMPILER)
+#    include <immintrin.h>
 #  endif
 #endif
 
@@ -65,7 +67,7 @@ class SpinLockMutex
 #if defined(_MSC_VER)
     YieldProcessor();
 #elif defined(__i386__) || defined(__x86_64__)
-#  if defined(__clang__)
+#  if defined(__clang__) || defined(__INTEL_COMPILER)
     _mm_pause();
 #  else
     __builtin_ia32_pause();

diff --git a/api/test/common/spinlock_benchmark.cc b/api/test/common/spinlock_benchmark.cc
@@ -87,7 +87,7 @@ static void BM_ProcYieldSpinLockThrashing(benchmark::State &s)
 #if defined(_MSC_VER)
           YieldProcessor();
 #elif defined(__i386__) || defined(__x86_64__)
-#  if defined(__clang__)
+#  if defined(__clang__) || defined(__INTEL_COMPILER)
           _mm_pause();
 #  else
           __builtin_ia32_pause();
Benchmark suite	Current: `8866c10`	Previous: `9dd19a2`	Ratio
`BM_BaselineBuffer/1`	`8239793.77746582` ns/iter	`489762.9041477566` ns/iter	`16.82`
`BM_BaselineBuffer/2`	`7172578.811645508` ns/iter	`3322465.419769287` ns/iter	`2.16`