Skip to content

Commit

Permalink
ZipkinExporter shutdown (#1153)
Browse files Browse the repository at this point in the history
  • Loading branch information
esigo authored Dec 20, 2021
1 parent 7b9132c commit 3701a6e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,7 @@ class ZipkinExporter final : public opentelemetry::sdk::trace::SpanExporter
* @param timeout an optional timeout, default to max.
*/
bool Shutdown(
std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override
{
return true;
}
std::chrono::microseconds timeout = std::chrono::microseconds::max()) noexcept override;

private:
void InitializeLocalEndpoint();
Expand Down
6 changes: 6 additions & 0 deletions exporters/zipkin/src/zipkin_exporter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ void ZipkinExporter::InitializeLocalEndpoint()
local_end_point_["port"] = url_parser_.port_;
}

bool ZipkinExporter::Shutdown(std::chrono::microseconds timeout) noexcept
{
isShutdown_ = true;
return true;
}

} // namespace zipkin
} // namespace exporter
OPENTELEMETRY_END_NAMESPACE

0 comments on commit 3701a6e

Please sign in to comment.