Skip to content

Commit

Permalink
[BUILD] Fix build without vcpkg on Windows when gRPC is disabled (#3016)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Corristo
Corristo authored Aug 2, 2024
1 parent eda6e93 commit 34ca855
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,8 @@ if(WITH_OTLP_GRPC
if(WITH_OTLP_GRPC)
find_package(gRPC)
endif()
if((NOT Protobuf_FOUND AND NOT PROTOBUF_FOUND) OR (NOT gRPC_FOUND))
if((NOT Protobuf_FOUND AND NOT PROTOBUF_FOUND) OR (WITH_OTLP_GRPC
AND NOT gRPC_FOUND))
if(WIN32 AND (NOT DEFINED CMAKE_TOOLCHAIN_FILE))
install_windows_deps()
endif()
Expand Down

2 comments on commit 34ca855

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 34ca855 Previous: eda6e93 Ratio
BM_SpinLockThrashing/1/process_time/real_time 0.6304556883654548 ms/iter 0.14190831593288755 ms/iter 4.44
BM_NaiveSpinLockThrashing/2/process_time/real_time 0.3567470641093721 ms/iter 0.17570642133553824 ms/iter 2.03

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 34ca855 Previous: eda6e93 Ratio
BM_BaselineBuffer/1 5057640.075683594 ns/iter 2293726.2058258057 ns/iter 2.20

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.