Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add log_level configuration #121

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add log_level configuration #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
858e4bc
add log_level configuration
codeboten Sep 16, 2024
d70ace3
Update examples/kitchen-sink.yaml
codeboten Sep 18, 2024
e6ae7dc
Merge branch 'main' into codeboten/add-log-level
codeboten Sep 19, 2024
7760e6d
Merge branch 'main' into codeboten/add-log-level
codeboten Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions examples/kitchen-sink.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ file_format: "0.1"
# Environment variable: OTEL_SDK_DISABLED
disabled: false

# Configure the log level of the internal logger used by the SDK
#
# Environment variable: OTEL_LOG_LEVEL
log_level: info

codeboten marked this conversation as resolved.
Show resolved Hide resolved
# Configure general attribute limits. See also tracer_provider.limits, logger_provider.limits.
attribute_limits:
# Configure max attribute value size.
Expand Down
3 changes: 3 additions & 0 deletions examples/sdk-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ file_format: "0.1"
# Configure if the SDK is disabled or not.
disabled: false

# Configure the log level used by the SDK logger
log_level: info

# Configure resource for all signals.
resource:
# Configure resource attributes.
Expand Down
4 changes: 3 additions & 1 deletion examples/sdk-migration-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# for more information. The following spec defined env vars are NOT referenced and are thus
# ignored:
#
# - OTEL_LOG_LEVEL
# - OTEL_PROPAGATORS
# - OTEL_TRACES_SAMPLER
# - OTEL_TRACES_SAMPLER_ARG
Expand All @@ -41,6 +40,9 @@ file_format: "0.1"
# Configure if the SDK is disabled or not.
disabled: ${OTEL_SDK_DISABLED:-false}

# Configure the log level used by the SDK logger
log_level: ${OTEL_LOG_LEVEL:-info}

# Configure resource for all signals.
resource:
# Configure resource attributes. Entries have higher priority than entries from .resource.attributes_list.
Expand Down
3 changes: 3 additions & 0 deletions schema/opentelemetry_configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
"disabled": {
"type": ["boolean", "null"]
},
"log_level": {
"type": ["string", "null"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have an enum based on a subset of the SeverityNumber enum defined in the proto repo? https://github.com/open-telemetry/opentelemetry-proto/blob/4f69356d853029975649c3f38b06fc77d77975fc/opentelemetry/proto/logs/v1/logs.proto#L86-L110

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, though without a resolution on open-telemetry/opentelemetry-specification#2039, we may be jumping ahead of the spec

},
"attribute_limits": {
"$ref": "#/$defs/AttributeLimits"
},
Expand Down
Loading