Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update httpconfig API to not include HTTP prefix #9453

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Feb 1, 2024

Following discussion #9403 (comment)

@dmitryax dmitryax requested review from a team and jpkrohling February 1, 2024 21:42
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3665732) 90.46% compared to head (95ebe48) 90.42%.

Files Patch % Lines
config/confighttp/confighttp.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9453      +/-   ##
==========================================
- Coverage   90.46%   90.42%   -0.05%     
==========================================
  Files         344      344              
  Lines       18024    18024              
==========================================
- Hits        16306    16298       -8     
- Misses       1390     1396       +6     
- Partials      328      330       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added Skip Contrib Tests release:blocker The issue must be resolved before cutting the next release labels Feb 1, 2024
@dmitryax
Copy link
Member Author

dmitryax commented Feb 1, 2024

Putting a release blocker to avoid spanning the breaking changes over two releases

@dmitryax dmitryax merged commit 7abb962 into open-telemetry:main Feb 2, 2024
32 of 33 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 2, 2024
@dmitryax dmitryax deleted the update-confighttp branch February 2, 2024 22:11
@bogdandrutu bogdandrutu removed the release:blocker The issue must be resolved before cutting the next release label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants