Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Move TracerProvider initialization to service/telemetry package #9384

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 24, 2024

Second redo of #8171 that does not depend on #9131

Link to tracking Issue: Updates #8170

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (abae649) 90.21% compared to head (b593245) 90.16%.

Files Patch % Lines
service/telemetry/telemetry.go 34.28% 18 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9384      +/-   ##
==========================================
- Coverage   90.21%   90.16%   -0.06%     
==========================================
  Files         345      345              
  Lines       18021    18019       -2     
==========================================
- Hits        16257    16246      -11     
- Misses       1435     1442       +7     
- Partials      329      331       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 24, 2024
@mx-psi mx-psi marked this pull request as ready for review January 24, 2024 18:15
@mx-psi mx-psi requested review from a team, jpkrohling and codeboten January 24, 2024 18:15
@codeboten codeboten merged commit 07a00ff into open-telemetry:main Jan 30, 2024
31 of 32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants