Make the option WithErrorUnused enabled by default when unmarshaling configuration
#9154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9154 +/- ##
==========================================
- Coverage 91.47% 91.39% -0.09%
==========================================
Files 320 320
Lines 17187 17191 +4
==========================================
- Hits 15722 15711 -11
- Misses 1165 1177 +12
- Partials 300 303 +3 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Dec 20, 2023
bogdandrutu
approved these changes
Dec 21, 2023
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jan 9, 2024
…arshaling configuration (open-telemetry#9154)" This reverts commit 6155cc2. I propose reverting this change as it's blocking the release. It's causing more problems and i'm not sure if there's a way to fix these tests as they call UnmarshalConfig which doesn't provide a way to pass in WithIgnoreUnused https://github.com/open-telemetry/opentelemetry-collector/blob/6a726c955a137f05f5d5ad402098f3220f42ceb6/component/config.go#L30-L36 See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7466429082/job/20317807463?pr=30167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make the option
WithErrorUnusedenabled by default when unmarshaling configurationThe option
WithErrorUnusedis now enabled by default, and a new optionWithIgnoreUnusedis introduced to ignoreerrors about unused fields.
Link to tracking Issue:
This relates to #7102 to some extent.
Testing:
N/A
Documentation:
N/A