Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record a metric with open census to ensure backwards compat #9065

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .chloggen/codeboten_use-otel-with-healthcheck-view.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: telemetry

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add OpenCensus view to useOtelForInternalMetrics path

# One or more tracking issues or pull requests related to the change
issues: [9065]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
This ensures the healthcheck extension which relies on an OpenCensus
view continues to work as it does today when a user enables useOtelForInternalMetrics.

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
9 changes: 9 additions & 0 deletions exporter/exporterhelper/obsexporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,15 @@ func (or *ObsReport) recordWithOtel(ctx context.Context, dataType component.Data

sentMeasure.Add(ctx, sent, metric.WithAttributes(or.otelAttrs...))
failedMeasure.Add(ctx, failed, metric.WithAttributes(or.otelAttrs...))
// This is here to ensure the current healthcheck extension continues
// to work even when using OpenTelemetry for collector metrics
if failed > 0 {
_ = stats.RecordWithTags(
ctx,
or.mutators,
obsmetrics.ExporterFailedToSendSpans.M(failed))
}

}

func (or *ObsReport) recordWithOC(ctx context.Context, dataType component.DataType, sent int64, failed int64) {
Expand Down
14 changes: 14 additions & 0 deletions service/telemetry.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

"go.opentelemetry.io/collector/config/configtelemetry"
"go.opentelemetry.io/collector/internal/obsreportconfig"
"go.opentelemetry.io/collector/internal/obsreportconfig/obsmetrics"
"go.opentelemetry.io/collector/service/internal/proctelemetry"
"go.opentelemetry.io/collector/service/internal/servicetelemetry"
"go.opentelemetry.io/collector/service/telemetry"
Expand Down Expand Up @@ -169,6 +170,19 @@
if err != nil {
return err
}

// This is here to ensure the current healthcheck extension continues
// to work even when using OpenTelemetry for collector metrics
healthcheckView := &view.View{
Name: obsmetrics.ExporterPrefix + "send_failed_requests",
Description: "number of times exporters failed to send requests to the destination",
Measure: obsmetrics.ExporterFailedToSendSpans,
Aggregation: view.Count(),
}
if err := view.Register(healthcheckView); err != nil {
return err
}

Check warning on line 184 in service/telemetry.go

View check run for this annotation

Codecov / codecov/patch

service/telemetry.go#L183-L184

Added lines #L183 - L184 were not covered by tests

tel.mp = mp
return nil
}
Expand Down
Loading