Set wait for ready in Jaeger gRPC exporter #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
pavolloffay
commented
Apr 30, 2020
exporter/jaegerexporter/exporter.go
Outdated
| @@ -80,7 +80,7 @@ func (s *protoGRPCSender) pushTraceData( | |||
| for _, batch := range batches { | |||
| _, err = s.client.PostSpans( | |||
| ctx, | |||
| &jaegerproto.PostSpansRequest{Batch: *batch}) | |||
| &jaegerproto.PostSpansRequest{Batch: *batch}, grpc.WaitForReady(true)) | |||
There was a problem hiding this comment.
This has to be configurable otherwise tests are failing.
Any objections on adding to the main gRPC config?
There was a problem hiding this comment.
I would like to read the documentation before saying anything. Will do that in 30 mins and confirm
|
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
grpc-wait-for-ready
branch
from
b9b2f78 to
b5fbaab
Compare
bogdandrutu
approved these changes
Apr 30, 2020
pjanotti
approved these changes
Apr 30, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
* Make wait for ready configurable in gRPC exporters Signed-off-by: Pavol Loffay <ploffay@redhat.com> * Fix Signed-off-by: Pavol Loffay <ploffay@redhat.com>
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Adds Database-specific semantic attributes. * Add CHANGELOG Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
gRPC can drop a couple of initial RPCs at the beginning of the connection. Wait for ready should prevent it.
Some resources:
This feature is needed in Jaeger to make crossdock tests pass. Sometimes Jaeger exporter drops first batches that is causing test failures. I have tested this PR in jaegertracing/jaeger#2211
Link to tracking Issue:
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>