[confighttp] add max_concurrent_connections to HTTPServerSettings #8633
Conversation
timannguyen
changed the title
|
@dmitryax do you happen to know who has capacity to review this? |
timannguyen
force-pushed
the
confighttp-maxconn
branch
from
f2f9b96 to
499d61c
Compare
|
adding @atoulme as well. We want to introduce this for splunkhecreceiver but this will modify the httpserversettings for every component that uses it. Do you know who is the right POC to consult about this change? |
timannguyen
force-pushed
the
confighttp-maxconn
branch
from
499d61c to
6a87a54
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
| // Enabled is set to enable opencensus metrics | ||
| Enabled bool `mapstructure:"enabled"` | ||
| // ExtraAttributes is the extra attributes for metrics | ||
| ExtraAttributes map[string]string `mapstructure:"extra_attributes"` |
There was a problem hiding this comment.
Why do you need this parameter? Collector provides a way to add extra resource attributes to the emitted metrics in the service::telemetry::resource config.
|
Let's hold off until discussion open-telemetry/opentelemetry-collector-contrib#27066 (comment) is resolved |
|
it looks that mem is what we are expecting. this would overall resolve the underlying issue. i've talked to @splunkericl. we're likely to close this out in favor of #8632 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description:
Adding
max_concurrent_connectionsto allow http server to limits http connection. this protects the server from being bombarded by tons of connection in-process and result in OOM.telemetry is an optional metrics to instrument httpserver with opencensus.
Link to tracking Issue:
open-telemetry/opentelemetry-collector-contrib#27066
Testing:
unit test
Documentation:
updated confighttp README with
max_concurrent_connectionsandtelemetry