[exporterhelper] Add WithRequestQueue option to the exporter #8275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
changed the title
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
from
e39b085
to
d3b012d
Compare
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
2 times, most recently
from
743f8d0
to
c66cf3f
Compare
dmitryax
changed the title
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
dmitryax
added a commit
that referenced
this pull request
Aug 30, 2023
Make the queue initialization process consistent for both queue types. Instead of having different workflows for memory and persistent queues, this change breaks the initialization of both into two generic steps: 1. Queue factory: `NewBoundedMemoryQueue`, `NewPersistentQueue` 2. Start method: `queue.Start(context.Context, component.Host, QueueSettings)` This change: - reduces coupling between `queuedRetrySender` and the queues; - allows future refactoring of `queuedRetrySender`; - allows future extraction of the queue package from the exporterhelper; - makes it possible to have `WithRequestQueue` option for the new exporter helper API as drafted in #8275.
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
5 times, most recently
from
beabbce
to
52172a6
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
2 times, most recently
from
37c8fc6
to
2d1aec3
Compare
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
3 times, most recently
from
c7c1138
to
2324e1a
Compare
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
3 times, most recently
from
5a349bf
to
d81d902
Compare
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
3 times, most recently
from
7817f94
to
a36cba4
Compare
codeboten
pushed a commit
that referenced
this pull request
Oct 5, 2023
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
from
a36cba4
to
0112f40
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
3 times, most recently
from
9eb77be
to
6f0ed5f
Compare
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
2 times, most recently
from
2e821ec
to
bc58c7f
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
exporter-helper-withqueue-option
branch
from
bc58c7f
to
efe2f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative interface for enabling queue in the new exporter helper as suggested in #8248 (comment)
Tracking issue: #8122