Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Prepare release v1.0.0-rcv0013/v0.80.0 #7939

Merged
merged 8 commits into from
Jun 20, 2023

Conversation

opentelemetrybot
Copy link
Contributor

The following commands were run to prepare this release:

  • make chlog-update VERSION=v1.0.0-rcv0013/v0.80.0
  • make prepare-release GH=none PREVIOUS_VERSION=1.0.0-rcv0012 RELEASE_CANDIDATE=1.0.0-rcv0013 MODSET=stable
  • make prepare-release GH=none PREVIOUS_VERSION=0.79.0 RELEASE_CANDIDATE=0.80.0 MODSET=beta

@opentelemetrybot opentelemetrybot requested review from a team and bogdandrutu June 20, 2023 15:52
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (25129b7) 91.05% compared to head (030b908) 91.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7939   +/-   ##
=======================================
  Coverage   91.05%   91.05%           
=======================================
  Files         298      298           
  Lines       14912    14912           
=======================================
  Hits        13578    13578           
  Misses       1057     1057           
  Partials      277      277           
Impacted Files Coverage Δ
cmd/builder/internal/builder/config.go 68.67% <ø> (ø)
cmd/otelcorecol/main.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Co-authored-by: Alex Boten <aboten@lightstep.com>
@@ -284,6 +284,8 @@ check-contrib:
@$(MAKE) -C $(CONTRIB_PATH) for-all CMD="$(GOCMD) mod edit -replace go.opentelemetry.io/collector/config/configtls=$(CURDIR)/config/configtls"
@$(MAKE) -C $(CONTRIB_PATH) for-all CMD="$(GOCMD) mod edit -replace go.opentelemetry.io/collector/config/internal=$(CURDIR)/config/internal"
@$(MAKE) -C $(CONTRIB_PATH) for-all CMD="$(GOCMD) mod edit -replace go.opentelemetry.io/collector/confmap=$(CURDIR)/confmap"
@$(MAKE) -C $(CONTRIB_PATH) for-all CMD="$(GOCMD) mod edit -replace go.opentelemetry.io/collector/connector=$(CURDIR)/connector"
@$(MAKE) -C $(CONTRIB_PATH) for-all CMD="$(GOCMD) mod edit -replace go.opentelemetry.io/collector/connector/forwardconnector=$(CURDIR)/connector/forwardconnector"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... this looks incorrect

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this change is appearing here. It's already been made on main and was brought into this branch by merging main into the source branch of this PR via #7944.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly because of the squash merge? It might be easier to close this pr and trigger a new one :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that's necessary, but I can do it if you'd prefer. It looks like this will still end up with the same end-state.

@codeboten codeboten merged commit 2a1bf71 into main Jun 20, 2023
@codeboten codeboten deleted the prepare-release-prs/0.80.0 branch June 20, 2023 17:31
@github-actions github-actions bot added this to the next release milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants