Add batchprocessor support for client metadata #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Mustin <mustin.eric@gmail.com>
Co-authored-by: Alex Boten <alex@boten.ca>
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
jmacd
changed the title
…tor into jmacd/batch_by_meta
added 2 commits
April 26, 2023 12:12
|
I screwed up the review history of #7325 (comment), so have created this replacement PR. Sorry I force-pushed and lost the review-comments by mistake. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7578 +/- ##
==========================================
- Coverage 91.23% 91.20% -0.03%
==========================================
Files 296 296
Lines 14472 14573 +101
==========================================
+ Hits 13203 13291 +88
- Misses 1004 1014 +10
- Partials 265 268 +3
☔ View full report in Codecov by Sentry. |
codeboten
reviewed
Apr 27, 2023
There was a problem hiding this comment.
Pinging approvers of the original PR to review here @jpkrohling @astencel-sumo @ericmustin
ericmustin
approved these changes
Apr 27, 2023
codeboten
reviewed
Apr 27, 2023
added 2 commits
May 3, 2023 07:22
…tor into jmacd/batch_by_meta
jpkrohling
approved these changes
May 12, 2023
gramidt
approved these changes
May 15, 2023
codeboten
approved these changes
May 15, 2023
dmitryax
approved these changes
May 16, 2023
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
May 22, 2023
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
May 22, 2023
jpkrohling
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Oct 24, 2023
The docs for the `headers_setter` extension state that the `from_context` config option does not work if the batch processor is used. I believe this comment is out of date, because it seems that the [PR](open-telemetry/opentelemetry-collector#7578) linked to the [issue](open-telemetry/opentelemetry-collector#4544) has been merged. Note that I haven't tested that this actually works with the header setter extension. Please let me know if you think testing is necessary. Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…etry#27465) The docs for the `headers_setter` extension state that the `from_context` config option does not work if the batch processor is used. I believe this comment is out of date, because it seems that the [PR](open-telemetry/opentelemetry-collector#7578) linked to the [issue](open-telemetry/opentelemetry-collector#4544) has been merged. Note that I haven't tested that this actually works with the header setter extension. Please let me know if you think testing is necessary. Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…etry#27465) The docs for the `headers_setter` extension state that the `from_context` config option does not work if the batch processor is used. I believe this comment is out of date, because it seems that the [PR](open-telemetry/opentelemetry-collector#7578) linked to the [issue](open-telemetry/opentelemetry-collector#4544) has been merged. Note that I haven't tested that this actually works with the header setter extension. Please let me know if you think testing is necessary. Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Re-do of #7325
Link to tracking Issue: #4544
Testing: One new test.
Documentation: README updated.