Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change publish jobs to attach to the correct workspace #731

Merged
merged 3 commits into from
Mar 28, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #731 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         162      162           
  Lines       11635    11635           
=======================================
  Hits         9838     9838           
  Misses       1396     1396           
  Partials      401      401           
Impacted Files Coverage Δ
translator/internaldata/resource_to_oc.go 73.13% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b598f...c686e90. Read the comment docs.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine but can you tell what workspace artifact it needed?

@pjanotti
Copy link
Contributor

Ok, I have the answer to my Q.:

#!/bin/bash -eo pipefail
make docker-otelcol
docker tag otelcol:latest otel/opentelemetry-collector-dev:${CIRCLE_SHA1:1}
docker tag otelcol:latest otel/opentelemetry-collector-dev:latest
make: *** No rule to make target 'docker-otelcol'.  Stop.

@bogdandrutu bogdandrutu merged commit a179762 into open-telemetry:master Mar 28, 2020
@bogdandrutu bogdandrutu deleted the attach branch March 28, 2020 04:52
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
Add api/standard package to implement semantic conventions
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants