Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move packages out of pkg to root #73

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Move packages out of pkg to root #73

merged 1 commit into from
Jun 28, 2019

Conversation

owais
Copy link
Contributor

@owais owais commented Jun 28, 2019

  • Moved /pkg/factories and /pkg/configv2 to /factories and /configv2
    respectively.
  • Moved /pkg/configmodels to /models

Discussed here: #69

- Moved /pkg/factories and /pkg/configv2 to /factories and /configv2
respectively.
- Moved /pkg/configmodels to /models
@codecov-io
Copy link

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is 95.58%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   71.37%   71.37%           
=======================================
  Files          91       91           
  Lines        6022     6022           
=======================================
  Hits         4298     4298           
  Misses       1500     1500           
  Partials      224      224
Impacted Files Coverage Δ
receiver/jaegerreceiver/config.go 50% <ø> (ø) ⬆️
factories/factories.go 100% <ø> (ø)
models/configmodels.go 0% <ø> (ø)
cmd/occollector/app/collector/collector.go 79.26% <ø> (ø) ⬆️
receiver/jaegerreceiver/factory.go 100% <100%> (ø) ⬆️
receiver/prometheusreceiver/factory.go 72.09% <100%> (ø) ⬆️
configv2/configv2.go 98.64% <100%> (ø)
cmd/occollector/app/builder/receivers_builder.go 85.18% <100%> (ø) ⬆️
exporter/opencensusexporter/factory.go 87.32% <100%> (ø) ⬆️
receiver/opencensusreceiver/factory.go 82.35% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e07643...9dfce20. Read the comment docs.

@tigrannajaryan
Copy link
Member

Can we use /config instead of /configv2?

@owais
Copy link
Contributor Author

owais commented Jun 28, 2019

Took a quick look and don't why not but it'll need more careful update as quite a few files are using config as an identifier. If we can live with configv2 for now, I'll try to spend some time cleaning up and moving to config may be next week.

@bogdandrutu
Copy link
Member

@tigrannajaryan that can be done in a separate PR. I would like to keep the PRs very granular.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree config vs. configv2 can be addressed in a separate PR.

@songy23 songy23 merged commit 07fc0f3 into open-telemetry:master Jun 28, 2019
@flands flands added this to the 0.1.0 milestone Jun 29, 2019
@owais owais deleted the move-outside-package branch June 29, 2019 01:35
pjanotti referenced this pull request in pjanotti/opentelemetry-service Jul 1, 2019
* Minimize the Docker image

Use a builder stage to minimize the final Docker image.

docker run -v config.yaml:/config.yaml  -p 55678:55678  <image>

Fixes #73.

* Use Go.11
jjackson-s pushed a commit to jjackson-s/opentelemetry-collector that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants