-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move packages out of pkg
to root
#73
Conversation
- Moved /pkg/factories and /pkg/configv2 to /factories and /configv2 respectively. - Moved /pkg/configmodels to /models
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 71.37% 71.37%
=======================================
Files 91 91
Lines 6022 6022
=======================================
Hits 4298 4298
Misses 1500 1500
Partials 224 224
Continue to review full report at Codecov.
|
Can we use |
Took a quick look and don't why not but it'll need more careful update as quite a few files are using |
@tigrannajaryan that can be done in a separate PR. I would like to keep the PRs very granular. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree config vs. configv2 can be addressed in a separate PR.
* Minimize the Docker image Use a builder stage to minimize the final Docker image. docker run -v config.yaml:/config.yaml -p 55678:55678 <image> Fixes #73. * Use Go.11
respectively.
Discussed here: #69