Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove otlp to/from oc converters and use internal converters #720

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #720 into master will increase coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
+ Coverage   78.48%   78.55%   +0.06%     
==========================================
  Files         163      161       -2     
  Lines       11866    11437     -429     
==========================================
- Hits         9313     8984     -329     
+ Misses       2129     2045      -84     
+ Partials      424      408      -16
Impacted Files Coverage Δ
translator/internaldata/traces_to_oc.go 78.4% <ø> (ø) ⬆️
translator/internaldata/oc_to_traces.go 85.1% <100%> (ø)
exporter/otlpexporter/otlp.go 63.33% <100%> (ø) ⬆️
receiver/otlpreceiver/trace/otlp.go 82.35% <75%> (+0.53%) ⬆️
translator/internaldata/resource_to_oc.go 67.16% <0%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48812d5...e51d881. Read the comment docs.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit 19cedfb into open-telemetry:master Mar 27, 2020
@bogdandrutu bogdandrutu deleted the rmwork branch March 27, 2020 02:16
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Move core to kv

* Move kv.Value to kv.value.Value

* Move key to kv
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
* fix operator pod roll update

* bump up

* ignore roleName annotation check

* update logical

* remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants