re-enable go vet, and fix warnings. #703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Older versions of golangci-lint do not work properly with go1.14, causing go vet to not be run.
Re-enabling it by switching it to v1.24.0 that works with go1.14, and fixing the lint errors that cropped up since switch to go1.14
Link to tracking Issue:
n/a
Testing:
make lint-static-check
Documentation:
None needed.