-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add receiver.Builder to help with creating components form a set of configs and factories #6803
Conversation
9e90c0b
to
413390d
Compare
Codecov ReportBase: 90.08% // Head: 89.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6803 +/- ##
==========================================
- Coverage 90.08% 89.90% -0.19%
==========================================
Files 246 248 +2
Lines 14246 14342 +96
==========================================
+ Hits 12834 12894 +60
- Misses 1163 1187 +24
- Partials 249 261 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
413390d
to
6901a8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement
6901a8e
to
2325358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea.
And we will do that for other component types, right? |
8d9532a
to
ff525cd
Compare
@dmitryax @djaglowski I am not convinced about the name of the type (Builder), here are some ideas:
|
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
ff525cd
to
f15d540
Compare
The main idea is that we pass a
receiver.Builder
(a combo of configs and factories that can create Receivers to the Service) instead of configs and factories separately. This way we help other distributions to re-implement service/host.