Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate configunmarshaler into generic implementation #6801

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

djaglowski
Copy link
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@djaglowski djaglowski changed the title Consolidate otelcol configunmarshaler into generic implementation Consolidate configunmarshaler into generic implementation Dec 14, 2022
@djaglowski djaglowski force-pushed the generic-configunmarshaler branch 2 times, most recently from 6e78132 to 0718d0a Compare December 14, 2022 19:57
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 90.14% // Head: 90.08% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (ccc370c) compared to base (921cf2e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6801      +/-   ##
==========================================
- Coverage   90.14%   90.08%   -0.06%     
==========================================
  Files         250      246       -4     
  Lines       14326    14245      -81     
==========================================
- Hits        12914    12833      -81     
  Misses       1163     1163              
  Partials      249      249              
Impacted Files Coverage Δ
otelcol/configprovider.go 78.57% <100.00%> (ø)
otelcol/internal/configunmarshaler/configs.go 100.00% <100.00%> (ø)
otelcol/unmarshaler.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski marked this pull request as ready for review December 14, 2022 20:09
@djaglowski djaglowski requested review from a team and bogdandrutu December 14, 2022 20:09
@bogdandrutu bogdandrutu merged commit a56b1af into open-telemetry:main Dec 14, 2022
@djaglowski djaglowski deleted the generic-configunmarshaler branch December 14, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants