Move shutdown telemetry to Service #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
shutdowntel
branch
from
ba556f2 to
013eacd
Compare
Codecov ReportBase: 89.64% // Head: 89.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6765 +/- ##
=======================================
Coverage 89.64% 89.64%
=======================================
Files 246 245 -1
Lines 14302 14245 -57
=======================================
- Hits 12821 12770 -51
+ Misses 1231 1225 -6
Partials 250 250
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dmitryax
reviewed
Dec 12, 2022
This removes any "private" dependency between Collector and Service and will allow to move collector to otelcol per the deprecation notice. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
shutdowntel
branch
from
013eacd to
42ccddc
Compare
dmitryax
approved these changes
Dec 12, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
This removes any "private" dependency between Collector and Service and will allow to move collector to otelcol per the deprecation notice. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
This removes any "private" dependency between Collector and Service and will allow to move collector to otelcol per the deprecation notice. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes any "private" dependency between Collector and Service and will allow to move collector to otelcol per the deprecation notice.
Updates #5564