Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example connector to service/internal/testcomponents #6762

Merged

Conversation

djaglowski
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 89.64% // Head: 89.34% // Decreases project coverage by -0.29% ⚠️

Coverage data is based on head (1b9ee58) compared to base (8222571).
Patch coverage: 11.11% of modified lines in pull request are covered.

❗ Current head 1b9ee58 differs from pull request most recent head 0bfb923. Consider uploading reports for the commit 0bfb923 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6762      +/-   ##
==========================================
- Coverage   89.64%   89.34%   -0.30%     
==========================================
  Files         246      247       +1     
  Lines       14302    14356      +54     
==========================================
+ Hits        12821    12827       +6     
- Misses       1231     1279      +48     
  Partials      250      250              
Impacted Files Coverage Δ
...rvice/internal/testcomponents/example_connector.go 11.11% <11.11%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski marked this pull request as ready for review December 12, 2022 21:06
@djaglowski djaglowski requested review from a team and bogdandrutu December 12, 2022 21:06
@djaglowski
Copy link
Member Author

/skipchangelog

@djaglowski
Copy link
Member Author

This is ready for review


// ExampleConnectorConfig config for ExampleConnector.
type ExampleConnectorConfig struct {
config.ConnectorSettings `mapstructure:",squash"` // squash ensures fields are correctly decoded in embedded struct
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this, see #6718

@djaglowski djaglowski force-pushed the service-example-connector branch from 1b9ee58 to 0bfb923 Compare December 12, 2022 22:43
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 12, 2022
@bogdandrutu bogdandrutu merged commit 052f761 into open-telemetry:main Dec 13, 2022
@djaglowski djaglowski deleted the service-example-connector branch December 13, 2022 01:38
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants