Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated comonent.Config.[ID|SetIDName]; Deprecate config.*Settings #6718
Remove deprecated comonent.Config.[ID|SetIDName]; Deprecate config.*Settings #6718
Changes from 1 commit
899c7e7
2bce1d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is probably not correct anymore, it can be applied to any configuration part now, not
component.Component
only, right?Do you have any further plans for this type? Do we even need it if it's just
interface{}
now?Also
UnmarshalConfig
doesn't seems to be applicable tocompoonent
module anymore. Do you think we should keep it here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand. The "component.Factory.CreateDefaultConfig" returns this object. If others are using it somewhere else that is their problem... What are you looking for here?
Good discussion if we need it. We can think in a future PR about that.
Same as previous, we can followup with more changes, for the moment the purpose of #4714 was to make sure we don't mutate the
Config
and that becomes an opaque object from the core collector perspective.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, so we still expect the Config to be mostly applied to Component even if it can be used with any other sub-configuration. That's what I was looking for
This file was deleted.