[chore] remove dependency on Factories, and LoadFiles in internal/pipelines #6661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elines Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
removeloadfile
branch
from
8a80d21 to
1e87b89
Compare
Codecov ReportBase: 91.18% // Head: 91.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6661 +/- ##
==========================================
- Coverage 91.18% 91.12% -0.06%
==========================================
Files 246 244 -2
Lines 14196 14160 -36
==========================================
- Hits 12945 12904 -41
- Misses 1001 1006 +5
Partials 250 250
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dmitryax
approved these changes
Dec 1, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
…elines (open-telemetry#6661) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
…elines (open-telemetry#6661) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation is to be able to move forward with splitting the component (where Factories will need to move most likely to
service)Updates #6578