Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split component into its own module #6543

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

codeboten
Copy link
Contributor

Fixes #6187

@codeboten codeboten requested review from a team and bogdandrutu November 14, 2022 23:34
@codeboten codeboten force-pushed the codeboten/split-components branch from 64360a9 to 32e4918 Compare November 14, 2022 23:44
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 91.33% // Head: 91.01% // Decreases project coverage by -0.31% ⚠️

Coverage data is based on head (ccf0bb4) compared to base (375a859).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6543      +/-   ##
==========================================
- Coverage   91.33%   91.01%   -0.32%     
==========================================
  Files         242      241       -1     
  Lines       13888    13885       -3     
==========================================
- Hits        12684    12637      -47     
- Misses        959     1008      +49     
+ Partials      245      240       -5     
Impacted Files Coverage Δ
receiver/otlpreceiver/config.go 94.44% <ø> (ø)
component/component.go 25.58% <0.00%> (-74.42%) ⬇️
component/config.go 0.00% <0.00%> (-40.00%) ⬇️
component/componenttest/nop_factories.go 0.00% <0.00%> (-29.42%) ⬇️
component/extension.go 86.66% <0.00%> (-13.34%) ⬇️
component/exporter.go 96.07% <0.00%> (-3.93%) ⬇️
component/receiver.go 96.07% <0.00%> (-3.93%) ⬇️
component/processor.go 96.07% <0.00%> (-3.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.chloggen/split-components.yaml Outdated Show resolved Hide resolved
@codeboten codeboten force-pushed the codeboten/split-components branch from 32e4918 to d153576 Compare November 15, 2022 19:32
@codeboten codeboten force-pushed the codeboten/split-components branch from d153576 to ccf0bb4 Compare November 15, 2022 19:47
@codeboten codeboten merged commit 19db2f1 into open-telemetry:main Nov 15, 2022
@codeboten codeboten deleted the codeboten/split-components branch November 15, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split component into its own module
2 participants