Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused member from confmap.Resolver #6489

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

bogdandrutu
Copy link
Member

This may be a breaking change, but should not be really important...

@bogdandrutu bogdandrutu requested review from a team and dmitryax November 7, 2022 22:37
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 7, 2022
Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a breaking change, but should not be really important...

I don't think we get to make that decision for users of this framework.

@bogdandrutu
Copy link
Member Author

@Aneurysm9 who gets?

@bogdandrutu
Copy link
Member Author

Extracting @Aneurysm9 comment from the Slack channel

I think that means it should be included in the changelog so that users who are trying to figure out what broke when they update aren’t stumped by missing changes in the changelog

I think it is a fair comment, doing that now.

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 7, 2022
@bogdandrutu bogdandrutu requested a review from Aneurysm9 November 7, 2022 23:18
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 91.65% // Head: 91.63% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (525a6a2) compared to base (3899d3e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6489      +/-   ##
==========================================
- Coverage   91.65%   91.63%   -0.02%     
==========================================
  Files         240      240              
  Lines       13817    13826       +9     
==========================================
+ Hits        12664    12670       +6     
- Misses        923      925       +2     
- Partials      230      231       +1     
Impacted Files Coverage Δ
confmap/resolver.go 96.34% <ø> (ø)
service/telemetry/telemetry.go 80.00% <0.00%> (-3.34%) ⬇️
service/unmarshaler.go 100.00% <0.00%> (ø)
service/telemetry/config.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu changed the title [chore] remove unused member from confmap.Resolver Remove unused member from confmap.Resolver Nov 7, 2022
@codeboten codeboten merged commit f411094 into open-telemetry:main Nov 8, 2022
@bogdandrutu bogdandrutu deleted the confmapmu branch November 8, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants