-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused member from confmap.Resolver #6489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a breaking change, but should not be really important...
I don't think we get to make that decision for users of this framework.
@Aneurysm9 who gets? |
Extracting @Aneurysm9 comment from the Slack channel
I think it is a fair comment, doing that now. |
Signed-off-by: Bogdan <bogdandrutu@gmail.com>
e533f15
to
525a6a2
Compare
Codecov ReportBase: 91.65% // Head: 91.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6489 +/- ##
==========================================
- Coverage 91.65% 91.63% -0.02%
==========================================
Files 240 240
Lines 13817 13826 +9
==========================================
+ Hits 12664 12670 +6
- Misses 923 925 +2
- Partials 230 231 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This may be a breaking change, but should not be really important...