Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default unmarshaler to service to avoid using deprecate configs #6395

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Oct 25, 2022

Remove already deprecates config.Service.

@bogdandrutu bogdandrutu force-pushed the mvunmarshaler branch 3 times, most recently from aa59c56 to b5e426d Compare October 27, 2022 17:52
@bogdandrutu bogdandrutu marked this pull request as ready for review October 27, 2022 17:52
@bogdandrutu bogdandrutu requested review from a team and tigrannajaryan October 27, 2022 17:52
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 91.82% // Head: 91.82% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7ded9e8) compared to base (3262fd8).
Patch coverage: 97.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6395      +/-   ##
==========================================
- Coverage   91.82%   91.82%   -0.01%     
==========================================
  Files         236      237       +1     
  Lines       13554    13549       -5     
==========================================
- Hits        12446    12441       -5     
  Misses        882      882              
  Partials      226      226              
Impacted Files Coverage Δ
service/config.go 100.00% <ø> (ø)
service/config_provider.go 78.57% <50.00%> (ø)
service/internal/configunmarshaler/error.go 100.00% <100.00%> (ø)
service/unmarshaler.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of non-blocking comments

service/unmarshaler.go Outdated Show resolved Hide resolved
service/internal/configunmarshaler/common.go Outdated Show resolved Hide resolved
Remove deprecated config.Service.

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 07603a0 into open-telemetry:main Oct 27, 2022
@bogdandrutu bogdandrutu deleted the mvunmarshaler branch October 27, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants