Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update tests to bind to localhost #6224

Merged

Conversation

codeboten
Copy link
Contributor

Update some tests to bind to localhost instead of 0.0.0.0

Update some tests to bind to localhost instead of 0.0.0.0
@codeboten codeboten requested review from a team and mx-psi October 3, 2022 19:27
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 91.87% // Head: 91.87% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5ec62dc) compared to base (711b882).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6224      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         219      219              
  Lines       13533    13544      +11     
==========================================
+ Hits        12434    12443       +9     
- Misses        870      872       +2     
  Partials      229      229              
Impacted Files Coverage Δ
pdata/pcommon/common.go 89.56% <33.33%> (-0.36%) ⬇️
service/telemetry.go 90.62% <0.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit 2570445 into open-telemetry:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants