otlpjson/trace: skip unknown fields instead of error #5931
Conversation
bogdandrutu
changed the title
bogdandrutu
force-pushed
the
fixjsonskip
branch
from
1c65625 to
8069869
Compare
Codecov Report
@@ Coverage Diff @@
## main #5931 +/- ##
=======================================
Coverage 91.94% 91.94%
=======================================
Files 199 199
Lines 12409 12409
=======================================
Hits 11409 11409
Misses 789 789
Partials 211 211
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…entations (open-telemetry#5929) * Added NewProtoSizer to instantiate Sizer implementations Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Updated changelog with PR number Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Refactored to create a MarshalSizer interface that is returned by NewProtoMarshaller Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Updated NewProtoMarshaler comments to inidicate return interface Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Corrected interface name Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
bogdandrutu
force-pushed
the
fixjsonskip
branch
from
8069869 to
d91c250
Compare
|
Does this change allow the collector to receive any json payload intending to be an OTEL span without any errors? So if a user sent |
|
Yes, but there is no way otherwise to support adding of new fields correct? The collector behavior is not define by decoding, the decoding will not error, but the receiver can return error that body is empty. |
|
Ya I guess we have to push that responsibility off to the receivers, otherwise the collector isn't forward/backwards compatible. |
|
Maybe there could be an option when starting the collector to allow strict enforcement versus skipping unknown values? Some users might want the enforcement. |
|
@TylerHelmuth let's think about that, would you mind opening an issue for that? I do believe that by default we should not fail. |
Done: #5935 |
|
Looks like link is the description is wrong |
|
@dmitryax good catch, PTAL |
Fixes #5312
Signed-off-by: Bogdan bogdandrutu@gmail.com