Deprecate duplicate settings in service.ConfigProvider, embed ResolverSettings #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rSettings. Signed-off-by: Bogdan <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
deprecateduplicate
branch
from
4e9948e
to
223ccee
Compare
Codecov Report
@@ Coverage Diff @@
## main #5843 +/- ##
==========================================
- Coverage 91.73% 91.66% -0.07%
==========================================
Files 195 195
Lines 11915 11926 +11
==========================================
+ Hits 10930 10932 +2
- Misses 777 783 +6
- Partials 208 211 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dmitryax
approved these changes
Aug 8, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan bogdandrutu@gmail.com