Run Windows unit tests for all modules and fix them #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5401 +/- ##
==========================================
- Coverage 91.00% 90.96% -0.04%
==========================================
Files 190 190
Lines 11428 11428
==========================================
- Hits 10400 10396 -4
- Misses 809 812 +3
- Partials 219 220 +1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
May 19, 2022
dmitryax
force-pushed
the
run-windows-tests
branch
6 times, most recently
from
874fa8c
to
b2a24d3
Compare
dmitryax
force-pushed
the
run-windows-tests
branch
from
b2a24d3
to
42b1e50
Compare
dmitryax
changed the title
|
@bogdandrutu I made additional changes to make the test pass. PTAL |
codeboten
approved these changes
May 24, 2022
bogdandrutu
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable running unit test on Windows for all modules and fix those that are failing except for one issue reported separately:
#5403