BreakingChange: Change to use interface instead of func for MapConverter

[bogdandrutu]

The main reason to do this, is because if in the future we want to extend the capabilities of the "MapConverter" we don't have any way to do that. By using an interface we can define "optional" interfaces that some converters may implement to enable future improvements.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

[codecov]

Codecov Report

Merging #5382 (d2e2b10) into main (ab79681) will decrease coverage by 0.05%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #5382      +/-   ##
==========================================
- Coverage   90.75%   90.70%   -0.06%     
==========================================
  Files         190      191       +1     
  Lines       11422    11423       +1     
==========================================
- Hits        10366    10361       -5     
- Misses        837      842       +5     
- Partials      219      220       +1     

Impacted Files	Coverage Δ
config/configmap.go	90.09% <ø> (ø)
config/mapconverter.go	0.00% <0.00%> (ø)
config/mapconverter/expandmapconverter/expand.go	100.00% <100.00%> (ø)
...rter/overwritepropertiesmapconverter/properties.go	100.00% <100.00%> (ø)
service/command.go	80.00% <100.00%> (ø)
service/config_provider.go	90.32% <100.00%> (ø)
service/mapresolver.go	93.10% <100.00%> (ø)
pdata/internal/common.go	91.82% <0.00%> (-0.75%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab79681...d2e2b10. Read the comment docs.

[codeboten]

I prefer the use of an interface as per the change. Is there a way to deprecate the existing converter's New functions before changing them? Otherwise this breaks the "breaking change" policy

[codeboten]

Missing version

[bogdandrutu]

Otherwise this breaks the "breaking change" policy

Indeed that's why it is called "braking change" and not deprecation, we need @open-telemetry/collector-approvers to say they are ok with this.

[bogdandrutu]

New functions before changing them

The result of the New function is only (I haven't seen any other way) used in the "converters" slice of service.ConfigProvider. So this will not be that disruptive for users, the most annoying will be if they implement converters by themselves...

[dmitryax]

I'm Ok with accepting this exception. This API doesn't seem to be widely adopted at this point

[tigrannajaryan]

I am OK with the change.

[bogdandrutu]

@codeboten ptal