-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce additional consumer packages split by telemetry type #5086
Conversation
f5144f3
to
d7fe504
Compare
Codecov Report
@@ Coverage Diff @@
## main #5086 +/- ##
=======================================
Coverage 90.11% 90.11%
=======================================
Files 183 183
Lines 11022 11022
=======================================
Hits 9932 9932
Misses 867 867
Partials 223 223
Continue to review full report at Codecov.
|
This change adds another set of packages representing "consumer" split by telemetry signal type. The same approach is taken as for the pdata split. Common parts are moved to internal package and then they are used from both existing combined and split consumer packages.
d7fe504
to
ff21a71
Compare
I think during the discussion about the split of |
My interpretation of what happened is "we agreed for now on pdata split and nothing else", not "we agreed not to split other packages". I agree if we were to split other stuff by telemetry type, it would need further discussion |
This was my understanding as well. And this PR is just to illustrate how further split can be done to support the further discussion. We need to do "something" with other packages using pdata in order to provide the backward compatible transition to the new pdata packages. This one is a simple example of what can be done for that, others can be more problematic to split, but we have to somehow rename/move them anyway. |
I was wrong here. We don't need to rename or split existing clients of the pdata packages to migrate it. There is a very nice side affect of the alias approach that we took: Since So we can split pdata packages and deprecate old ones right away. Just need to agree on which pdata structure we are going to use: |
This change adds another set of packages representing "consumer" split by telemetry signal type. The same approach is taken as for the pdata split. Common parts are moved to internal package and then they are used from both existing combined and split consumer packages.
This is just one step towards splitting the pdata usage to illustrate one option of new pdata structure as suggested in this PR: #4918