Change batch processor to use otel instead of oc #4489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Should I just close this? From what I remember, we are still not ready to use otel-sdk given the lack of support for views, which makes us unable to have a bucket set per measure/metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the first step towards documenting how component owners can create telemetry data to observe their components. This PR changes the batch processor, migrating from OpenCensus to OpenTelemetry API, using the provided MeterProvider from the ProcessorCreateSettings.
One thing this PR is still missing is to provide the views, which would likely work in a way that is similar to what we have today.
The proposal in this PR is mainly to start a discussion on whether this is the pattern we want to recommend. Once we establish the pattern, I'll work on getting the tests to work.
Relates to #4198
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de