move cmd/pdatagen -> model/internal/cmd/pdatagen #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4243 +/- ##
==========================================
+ Coverage 87.92% 88.07% +0.14%
==========================================
Files 173 173
Lines 10263 10188 -75
==========================================
- Hits 9024 8973 -51
+ Misses 993 975 -18
+ Partials 246 240 -6
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Oct 22, 2021
Makefile
Outdated
| @@ -360,7 +360,7 @@ genproto_sub: | |||
| # Generate structs, functions and tests for pdata package. Must be used after any changes | |||
| # to proto and after running `make genproto` | |||
| genpdata: | |||
| go run cmd/pdatagen/main.go | |||
| go run model/internal/pdatagen/main.go | |||
codeboten
changed the title
bogdandrutu
approved these changes
Oct 22, 2021
carlosalberto
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
moving
cmd/pdatagencode tomodel/internalLink to tracking Issue: Fixes #4241
This is just the move of the package over, I can move
model/internal/pdatagen/internalnext, but wanted to minimize the changes in this PR.