Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the Prometheus configuration #3589

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Validate the Prometheus configuration #3589

merged 2 commits into from
Jul 13, 2021

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Jul 9, 2021

Validate against nil configuration and configuration with no scrape_configs.

Fixes #2705.

Validate against nil configuration and configuration with no scrape_configs.

Fixes #2705.
@rakyll rakyll requested a review from alolita as a code owner July 9, 2021 21:44
@rakyll rakyll requested review from a team and dmitryax July 9, 2021 21:44
@bogdandrutu
Copy link
Member

Windows and Linux unittest are failing

@rakyll
Copy link
Contributor Author

rakyll commented Jul 12, 2021

Fixed, PTAL.

@bogdandrutu bogdandrutu merged commit ae42627 into open-telemetry:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus receiver crashes on startup
3 participants