Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internal data wrappers to model/internal #3514

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

bogdandrutu
Copy link
Member

Updates #3104

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and dmitryax June 29, 2021 12:40
@jrcamp
Copy link
Contributor

jrcamp commented Jun 29, 2021

modelinternal maybe instead of internal2?

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu
Copy link
Member Author

@jrcamp done, goland is stupid, when moving to same package name but different path it does this, even though you move the entire package and no conflicts will happen.

@bogdandrutu bogdandrutu merged commit 3acff6c into open-telemetry:main Jun 29, 2021
@bogdandrutu bogdandrutu deleted the mvwrapper branch June 29, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants