Add encoder/decoder and marshaler/unmarshaler for OTLP protobuf #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Jun 9, 2021
This was referenced Jun 9, 2021
carlosalberto
approved these changes
Jun 9, 2021
jrcamp
approved these changes
Jun 9, 2021
| otlpcollectortrace "go.opentelemetry.io/collector/internal/data/protogen/collector/trace/v1" | ||
| ) | ||
|
|
||
| type pbDecoder struct{} |
There was a problem hiding this comment.
Personally I'd just use protobuf instead of pb throughout.
There was a problem hiding this comment.
this is internal, so I don't think it is a problem :)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
oltpprotobuf
branch
from
ce31fce
to
8a610b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3104
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com