Log dropped metric count when exporting from PRW exporter #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
approved these changes
May 26, 2021
| @@ -158,7 +161,8 @@ func (prwe *PRWExporter) PushMetrics(ctx context.Context, md pdata.Metrics) erro | |||
| errs = append(errs, exportErrors...) | |||
| } | |||
|
|
|||
| if dropped != 0 { | |||
| if dropped > 0 { | |||
| prwe.logger.Info("Prometheus remote write dropped metrics", zap.Int("dropped_count", dropped)) | |||
There was a problem hiding this comment.
This can potentially flood the logs. We shouldn't be doing this. See https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#logging
I believe all exporters record dropped metrics, which presumably is sufficient for observing the Collector. If we need a different way observe dropped data we need to explain why and we would prefer it to be uniform for all exporters, not special just for Prometheus.
There was a problem hiding this comment.
The metrics would work in this case. I opened the PR due to my lack of awareness of the builtin metrics. I'll close this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/wg-prometheus#13.