Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typo in kafkareceiver and kafkaexporter package #2955

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Fix some typo in kafkareceiver and kafkaexporter package #2955

merged 1 commit into from
Apr 19, 2021

Conversation

hanjm
Copy link
Member

@hanjm hanjm commented Apr 17, 2021

Description:
Fix some typo in kafkareceiver and kafkaexporter package

@hanjm hanjm requested a review from a team April 17, 2021 01:14
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #2955 (2857652) into main (90b2dec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2955   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         312      312           
  Lines       15351    15351           
=======================================
  Hits        14059    14059           
  Misses        883      883           
  Partials      409      409           
Impacted Files Coverage Δ
receiver/kafkareceiver/factory.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b2dec...2857652. Read the comment docs.

@hanjm
Copy link
Member Author

hanjm commented Apr 17, 2021

Hello, I am using kafka exporter and receiver, then find some logic problem( issue #2956 fixed by #2957 ) and typo problem. simply first, i fix some typo.

service:
  pipelines:
    traces/producer:
      receivers: [otlp, opencensus, jaeger, zipkin]
      exporters: [kafka]
    traces/consumer:
      receivers: [kafka]
      processors: [batch]
      exporters: [logging]

@bogdandrutu bogdandrutu merged commit 0627fa8 into open-telemetry:main Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants